“Donor-advised funds have been a bad deal for American society. They have produced too many private benefits for the financial services industry, at too great a cost to the taxpaying public, and they have provided too few benefits for society at large. When we consider their overall effect, we see that rather than supporting working charities and the beneficiaries they serve, they have undermined them.”